Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jar mode execution ci pipeline and status json add [not ready] #241

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tahiat
Copy link
Collaborator

@tahiat tahiat commented Apr 10, 2024

No description provided.

@tahiat tahiat changed the title Jar mode execution ci pipeline and status json add Jar mode execution ci pipeline and status json add [depends on https://github.com/tahiat/specimin-evaluation/pull/37] Apr 10, 2024
@tahiat tahiat changed the title Jar mode execution ci pipeline and status json add [depends on https://github.com/tahiat/specimin-evaluation/pull/37] Jar mode execution ci pipeline and status json add [not ready] Apr 10, 2024
@tahiat
Copy link
Collaborator Author

tahiat commented Apr 10, 2024

depends on tahiat/specimin-evaluation#37

@@ -0,0 +1,23 @@
{
"cf-1291": "FAIL",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these all FAIL? Is it because specimin-evaluation#37 hasn't yet been merged, so you don't know? Or are they actually all failing in local testing (if so, that's a crisis).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Professor, I only configured jar mode for cf-6282, other project is not yet configured for jar mode.
in jar mode, specimin producing minimized program for cf-6282. However compilation is failing for the minimized program.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The printed table will show the reason of failure

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious. Did you use the jar files when compiling these projects? In essence, whichever jar files given to Specimin should also be used when compiling the minimized programs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right Loi, I did not use the jars when compiling these minimized projects. I need to modify the gradle script to use the jars. Now configuring that.

@tahiat tahiat requested review from kelloggm and LoiNguyenCS April 11, 2024 19:11
@@ -0,0 +1,22 @@
{
"cf-1291": "FAIL",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these accurate? If so, that's very concerning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Projects where I could not write the script to pull dependencies, specimin was not run on them and results are showing as FAIL.
specimin was not executed on cf-1291 in jar mode. Thats why status is FAIL

@@ -76,6 +76,8 @@ public static void main(String... args) throws IOException {
jarFiles = getJarFiles(jarDirectory);
}

jarFiles.stream().forEach(System.out::println);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be removed before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants